Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jamin - JACK Audio Mastering interface https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225114 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-04-25 14:07 EST ------- Just to confirm... No one has reviewed this for 3 months. Florin, do you still want to import this to Fedora? This is just I want to make it sure if you are still watching this review request. (In reply to comment #2) > I don't know if I have to bump the Release number after every rebuild like > this, so I'm just using the same number. You *have to*. Well, from just I glanced at your spec file: * Source URL - Please refer to http://fedoraproject.org/wiki/Packaging/SourceURL for sourceforge.net source URL * Using autotool - Generally calling autotool is not preferred for several reasons. If possible, patch against configure, not configure.in, for example * Deprecated categories - Categories "Application" "X-Fedora" are both deprecated for desktop file categories and should be removed. * Directory ownership - _Perhaps_ %{_libdir}/ladspa is not owned by any package (I have not tried to rebuild this package) * %exclude - Please don't use %exclude when it can. Just remove the file at %install stage. * Mimeinfo - Please check "mimeinfo" section of http://fedoraproject.org/wiki/Packaging/ScriptletSnippets -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review