[Bug 1134742] Review Request: python-requests-mock - A requests mocking tool for python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1134742



--- Comment #4 from Kashyap Chamarthy <kchamart@xxxxxxxxxx> ---
So, I think we need a V2 of SPEC (don't forget to bump up the Release), and its
corresponding new SRPM.

Comments:

  (1) Please wrap the description text to 72 characters
  (2) Remove the egg info in %prep, something like:

      # Remove bundled egg-info
      rm -rf %{pypi_name}.egg-info

  (3) You can remove 

        CFLAGS="$RPM_OPT_FLAGS"

     from %build section. It's not needed for noarch packages.

  (4) About the "*No copyright* Apache (v2.0)":
       - (C) notice is not required, everything is (C) by default
         
http://en.wikipedia.org/wiki/Copyright#Copyright_notices_in_the_United_States
       - And, all the said files have licesnse text in it. So, no action
         needed here.
  (5) Directories without known owners:
      /usr/lib/python3.4/site-packages, /usr/lib/python3.4
        - Standard directories, so this is fine. No action needed here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]