[Bug 1135503] Review Request: khelpcenter - Application to show KDE Application's documentation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1135503

Christopher Meng <i@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |i@xxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |i@xxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Christopher Meng <i@xxxxxxxx> ---
1. 

Checking: khelpcenter-5.0.1-1.fc22.i686.rpm
          khelpcenter-5.0.1-1.fc22.src.rpm
khelpcenter.i686: E: invalid-soname /usr/lib/libkdeinit5_khelpcenter.so
libkdeinit5_khelpcenter.so
khelpcenter.i686: W: hidden-file-or-dir
/usr/share/khelpcenter/plugins/Scrollkeeper/.directory
khelpcenter.i686: W: hidden-file-or-dir
/usr/share/khelpcenter/plugins/Manpages/.directory
khelpcenter.i686: W: hidden-file-or-dir
/usr/share/khelpcenter/plugins/Applications/.directory
khelpcenter.i686: W: no-manual-page-for-binary khelpcenter
khelpcenter.src: W: strange-permission khelpcenter-5.0.1.tar.xz 0640L
2 packages and 0 specfiles checked; 1 errors, 5 warnings.

i. Are these . files useful?

ii. What about the soname? Is it expected?

2. Just a hint:

%{_datadir}/doc -> %{_docdir}

3. Pick one line:

[ 97%] Building CXX object
CMakeFiles/kdeinit_khelpcenter.dir/searchhandler.cpp.o
/usr/bin/c++   -DKCOREADDONS_LIB -DKGUIADDONS_LIB -DQT_CORE_LIB -DQT_DBUS_LIB
-DQT_DISABLE_DEPRECATED_BEFORE=0 -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG
-DQT_PRINTSUPPORT_LIB -DQT_WIDGETS_LIB -DQT_XML_LIB -D_FILE_OFFSET_BITS=64
-D_GNU_SOURCE -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500
-Dkdeinit_khelpcenter_EXPORTS -O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
--param=ssp-buffer-size=4 -grecord-gcc-switches  -m32 -march=i686 -mtune=atom
-fasynchronous-unwind-tables  -std=c++0x -fno-exceptions -Wall -Wextra
-Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith
-Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -O3
-DNDEBUG -fPIC -fvisibility=hidden -fvisibility-inlines-hidden
-I/builddir/build/BUILD/khelpcenter-5.0.1/i686-redhat-linux-gnu
-I/builddir/build/BUILD/khelpcenter-5.0.1 -isystem /usr/include/KF5/KHtml
-isystem /usr/include/KF5 -isystem /usr/include/qt5 -isystem
/usr/include/qt5/QtGui -isystem /usr/include/qt5/QtCore -isystem
/usr/lib/qt5/mkspecs/linux-g++ -isystem /usr/include/KF5/KIOCore -isystem
/usr/include/KF5/KCoreAddons -isystem /usr/include/KF5/KService -isystem
/usr/include/KF5/KConfigCore -isystem /usr/include/KF5/KI18n -isystem
/usr/include/KF5/KParts -I/usr/include/KF5/KIOWidgets
-I/usr/include/KF5/KJobWidgets -isystem /usr/include/qt5/QtWidgets
-I/usr/include/qt5/QtNetwork -isystem /usr/include/KF5/KCompletion -isystem
/usr/include/KF5/KWidgetsAddons -I/usr/include/KF5/KXmlGui -isystem
/usr/include/qt5/QtDBus -isystem /usr/include/qt5/QtXml -isystem
/usr/include/KF5/KConfigWidgets -I/usr/include/KF5/KCodecs
-I/usr/include/KF5/KConfigGui -I/usr/include/KF5/KAuth -isystem
/usr/include/KF5/KTextWidgets -I/usr/include/KF5/SonnetUi -isystem
/usr/include/KF5/KCMUtils -isystem /usr/include/KF5/KDBusAddons -isystem
/usr/include/KF5/KDELibs4Support -isystem /usr/include/KF5/KDELibs4Support/KDE
-isystem /usr/include/qt5/QtPrintSupport -isystem /usr/include/KF5/KCrash
-isystem /usr/include/KF5/KIOFileWidgets -I/usr/include/KF5/KBookmarks
-I/usr/include/KF5/KItemViews -I/usr/include/KF5/Solid -isystem
/usr/include/KF5/KNotifications -isystem /usr/include/KF5/KIconThemes -isystem
/usr/include/KF5/KWindowSystem -isystem /usr/include/KF5/KGuiAddons -isystem
/usr/include/KF5/KUnitConversion    -o
CMakeFiles/kdeinit_khelpcenter.dir/searchhandler.cpp.o -c
/builddir/build/BUILD/khelpcenter-5.0.1/searchhandler.cpp

Looks like O3 is being used and overriding optflags, does Fedora allow O3 to be
used in KDE?

Others are fine.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]