https://bugzilla.redhat.com/show_bug.cgi?id=1134020 --- Comment #10 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- (In reply to Florian "der-flo" Lehner from comment #9) > hi! > > Looks good, but hrere are still some issues: > > [ ] You didn't increase the release number This is not compulsory. Please see https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Multiple_Changelog_Entries_per_Release > > [ ] Source0 doesn't work. > Please replace > > https://github.com/%{module_name}/%{module_name}/archive/%{module_name}- > %{commit}.tar.gz > with > https://github.com/%{module_name}/%{module_name}/archive/%{commit}.tar.gz I cannot use the second one. It must end with %{module_name}-%{commit}.tar.gz for rpmbuild to find the source tar. I've updated the source url as per http://fedoraproject.org/wiki/Packaging:SourceURL#Github (I missed out a /%{commit}/ in the URL). It works now. > [ ] In the first %files-section is %doc COPYING missing Moved COPYING to main packages from doc subpackages. Spec URL: https://ankursinha.fedorapeople.org/pykalman/python-pykalman.spec SRPM URL: https://ankursinha.fedorapeople.org/pykalman/python-pykalman-0.9.5-1.20140827git2aeb4ad.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review