https://bugzilla.redhat.com/show_bug.cgi?id=1106415 --- Comment #3 from MartinKG <mgansser@xxxxxxxx> --- (In reply to NIWA Hideyuki from comment #2) > Hi > This is my informal review. I comment about the spec file etc. > > 1. Source0: sayonara-player-%{svnrev}.tar.gz > > URL is necessary for the Source0 tag. There is no URL available for the recent snv tarball. > > 2. # > https://sayonara-player.googlecode.com/issues/ > attachment?aid=920000000&name=sayonara-desktop. > patch&token=ABZ6GAezT8Y7uTPdlcAPejNluH3R5pcUiQ%3A1402298727539 > Patch0: sayonara-desktop.patch > # > https://sayonara-player.googlecode.com/issues/ > attachment?aid=920000001&name=sayonara-libdir. > patch&token=ABZ6GAftNAWKGIQtU8vT9AwhapN1BEXTdw%3A1402298727539 > Patch1: sayonara-libdir.patch > > When the brief comment is put on the upper part of Patch0 and Patch1 > above upstream bug tracker link, it is helpful. > done > 3. BuildRequires: cmake > BuildRequires: desktop-file-utils > BuildRequires: qt-devel > BuildRequires: alsa-lib-devel > BuildRequires: gstreamer-devel > BuildRequires: gstreamer-plugins-base-devel > BuildRequires: libnotify-devel > Buildrequires: curl-devel > BuildRequires: libxml2-devel > BuildRequires: taglib-devel > BuildRequires: glib2-devel > Requires: svn > > Please add comments on explicit dependencies. > remove unnecessary dependencies > 4. rm -rf %{buildroot}/%{_datadir}/menu > > Is this processing necessary? Please delete it if it is unnecessary. its necessary Spec URL: https://www.dropbox.com/s/2cnhsow8i72mput/sayonara.spec?dl=0 SRPM URL: https://www.dropbox.com/s/f8vgj2c7whhv4ze/sayonara-0.4.1-1.3.svn870.fc20.src.rpm?dl=0 %changelog * Fri Aug 29 2014 Martin Gansser <martinkg@xxxxxxxxxxxxxxxxx> - 0.4.1-1.3.svn870 - rebuild for new svn release - added more comments rpmlint sayonara-debuginfo-0.4.1-1.3.svn870.fc20.x86_64.rpm sayonara-debuginfo.x86_64: E: debuginfo-without-sources 1 packages and 0 specfiles checked; 1 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review