https://bugzilla.redhat.com/show_bug.cgi?id=1134835 --- Comment #10 from David Parsons <david.parsons@xxxxxxxx> --- Hi Christopher and thank you for adding your comments. I had seen that point 1. (BR gcc-c++) wasn't needed but I thought it was harmless so I had left it in. I will remove it. For point 2. I'm wondering whether it is useful to target EPEL5 as well as EPEL6. However, if EPEL5 is still being used, I suppose it would be best to support it and hence keep the "rm -rf %{buildroot}" statement in the %install section. As for point 3. I had read this: http://fedoraproject.org/wiki/Packaging:Guidelines#Libexecdir (files in lib are indeed "executable programs that are designed primarily to be run by other programs rather than by users") but hadn't actually grasped that %{_libdir} would be /usr/lib64 on X86_64. I understand I have to change the install dir of these files. However I do not know how to do this provided that upstream do not offer the possibility to choose the lib dir. These files are consistently placed in $prefix/lib/kissplice/ Can you help me with this ? Thanks, David -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review