https://bugzilla.redhat.com/show_bug.cgi?id=1135413 Josef Stribny <jstribny@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Josef Stribny <jstribny@xxxxxxxxxx> --- 1, # %%gem_install compiles any C extensions and installs the gem into ./%%gem_dir This comment is tricky for me as it suggests that there might be a C extension. This is not the case for celluloid though. 2, Unnecessary BuildRequires: BuildRequires: ruby(release) BuildRequires: rubygems-devel >= 1.3.6 BuildRequires: ruby >= 1.9.2 BuildRequires: rubygems-devel should be enough. (We should probably change the template in gem2rpm to address this.) Both are minor issues that can solved before pushing. The package builds, installs, runs, tests are passing, rpmlint doesn't complain and the spec looks sane ==> APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review