https://bugzilla.redhat.com/show_bug.cgi?id=1129902 Eduardo Mayorga <e@xxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e@xxxxxxxxxxxxxxxx Flags| |fedora-review? --- Comment #3 from Eduardo Mayorga <e@xxxxxxxxxxxxxxxx> --- A few notes: - You must include a license file if upstream decides to not distribute a license text copy. See: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text - You need to fix the shebang for both, python2 and python3 scripts. This can solve the problem: %if 0%{?with_python3} rm -rf %{py3dir} cp -a . %{py3dir} find %{py3dir} -name '*.py' | xargs sed -i '1s|^#!python|#!%{__python3}|' %endif # with_python3 find -name '*.py' | xargs sed -i '1s|^#!python|#!%{__python2}|' - rpmlint warnings need attention. "gitapi is a"... in the summary is superfluous. It's better just to leave it as Pure-Python API to git... (note it's capitalized). And for wrong-script-end-of-line-encoding, see: http://fedoraproject.org/wiki/Common_Rpmlint_issues#wrong-file-end-of-line-encoding -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review