[Bug 1130185] Review Request: python-icontrol - Library for F5 iControl API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1130185

Eduardo Mayorga <e@xxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |e@xxxxxxxxxxxxxxxx



--- Comment #1 from Eduardo Mayorga <e@xxxxxxxxxxxxxxxx> ---
- Remove egg-info directory in %prep.

- These are obsolete:
BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

%clean
rm -rf %{buildroot}

and there's no need to add rm -rf %{buildroot} in %install

- You must include a license text in %doc. Since this project seems not to be
maintained, it will be tricky to get this mistake corrected. For now, please
add a copy of the text of the GPL. Something like Source1: COPYING would be
fine.

- Change the name to python-pycontrol, since it's the name used by upstream and
the actual module name used to import it in a script

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]