[Bug 1132670] Review Request: rubygem-compass-core - The Compass core stylesheet library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1132670



--- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
* The .spec differences
  - The .spec file you posted differs from the one included in SRPM. It is just
    small difference in you name in %changelog, so no big deal.

* Update to the latest guidelines
  - The .spec file looks to be generated by old gem2rpm and does not conform
    to the latest Ruby packaging guidelines. Please remove the Requires, which
    are now autogenerated and Provides.

* Test suite is not executed.
  - Please execute the test suite.
  - Although it is not shipped with the gem, it is available upstream [1].

* md5 usage
  - it seems that Compass uses md5 in
    lib/compass/core/sass_extensions/functions/files.rb . Since this hash
    algorithm is considered insecure and it is not supported on FIPS compliant
    machines, could you please query upstream about it? This is not blocker,
    just NTH issue I noticed.


[1] https://github.com/Compass/compass/tree/stable/core

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]