[Bug 1132661] Review Request: atom - Atom editor from github

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1132661

Christopher Meng <i@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |i@xxxxxxxx
             Blocks|                            |177841 (FE-NEEDSPONSOR)
            Summary|Review Request: nodejs-atom |Review Request: atom - Atom
                   |- Atom editor from github   |editor from github



--- Comment #5 from Christopher Meng <i@xxxxxxxx> ---
You shouldn't "install -pm755 %{buildroot}%{_datadir}/atom/libudev.so.0
%{buildroot}%{_libdir}". It's dangerous.

This package is full of craps and bundled libraries. Your copr also failed to
build the latest as well. As Fedora doesn't have that version of gyp. Please,
next time don't use your custom repo to build the dependencies.

I don't think this package could be easily reviewed and get passed.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]