[Bug 1131731] Review Request: php-pimple - A simple dependency injection container for PHP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1131731



--- Comment #6 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> ---
[!]: Requires correct, justified where necessary.

php-reflection detected by phpcompatinfo
Ok, this one is always present, but, to be consistent, 
as you BR it, you should also require it. (minor)

[!]: Package functions as described.

Pimple/Pimple.php compatibility class is unusable

Without the C extension, the include must come before the class_alias, else:

    Warning: Class 'Pimple\Container' not found in
/usr/share/php/Pimple/Pimple.php on line 10


"BUT", with the C extension

    Fatal error: Cannot redeclare class Pimple\Container in
/usr/share/php/Pimple/Container.php on line 34

Indeed, Pimple\Container is provided by the C extension, the .php file is only
for compatibility when the C extension not available.

And making the include conditional, like:

    if (!extension_loaded("pimple")) {
        include __DIR__ . '/Container.php';
    }
    class_alias('Pimple\Container', 'Pimple');

Doesn't work...

    Warning: First argument of class_alias() must be a name of user defined
class in /usr/share/php/Pimple/Pimple.php on line 13


This means:
- the PHP library is not needed with the C extension
- the compatibility cannot be provided (so probably php-pimple should only
obsolete php-Pimple in rawhide)


Any other solution welcome...
For now, I don't really have the "right" answer to this issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]