https://bugzilla.redhat.com/show_bug.cgi?id=1133217 Pierre-YvesChibon <pingou@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |pingou@xxxxxxxxxxxx --- Comment #4 from Pierre-YvesChibon <pingou@xxxxxxxxxxxx> --- * Spec is clean * License is CC-BY-SA ! Why the strange %version tag? I guess I can see a relation with Fedora 21 alpha, thus version is pre 21, but since the package is named f21, why not just use 0.1 for alpha, 0.2 for beta and 1.0 for release? ? You know probably better than I, but why is KDE having F21 while all the other desktops have f21? * builds fine on F20 * rpmlint: f21-backgrounds.noarch: W: no-documentation f21-backgrounds-kde.noarch: W: no-documentation f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1680x1050.png ../../../../backgrounds/f21/default/wide/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/640x480.png ../../../../backgrounds/f21/default/standard/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1024x768.png ../../../../backgrounds/f21/default/standard/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/2048x1536.png ../../../../backgrounds/f21/default/standard/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1024x600.png ../../../../backgrounds/f21/default/tv-wide/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1440x900.png ../../../../backgrounds/f21/default/wide/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1280x720.png ../../../../backgrounds/f21/default/tv-wide/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1280x768.png ../../../../backgrounds/f21/default/wide/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1920x1080.png ../../../../backgrounds/f21/default/tv-wide/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1366x768.png ../../../../backgrounds/f21/default/tv-wide/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/800x480.png ../../../../backgrounds/f21/default/wide/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1280x1024.png ../../../../backgrounds/f21/default/normalish/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1152x864.png ../../../../backgrounds/f21/default/standard/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1600x1280.png ../../../../backgrounds/f21/default/standard/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1280x800.png ../../../../backgrounds/f21/default/wide/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1200x900.png ../../../../backgrounds/f21/default/standard/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/800x600.png ../../../../backgrounds/f21/default/standard/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1280x960.png ../../../../backgrounds/f21/default/standard/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1152x720.png ../../../../backgrounds/f21/default/wide/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1600x1200.png ../../../../backgrounds/f21/default/standard/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1920x1440.png ../../../../backgrounds/f21/default/standard/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1920x1200.png ../../../../backgrounds/f21/default/wide/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1440x1080.png ../../../../backgrounds/f21/default/standard/f21.png f21-backgrounds-gnome.noarch: W: no-documentation f21-backgrounds-mate.noarch: W: no-documentation f21-backgrounds-xfce.noarch: W: no-documentation f21-backgrounds-xfce.noarch: W: dangling-relative-symlink /usr/share/xfce4/backdrops/f21.png ../../backgrounds/f21/default/wide/f21.png 6 packages and 0 specfiles checked; 0 errors, 29 warnings. http://fedoraproject.org/wiki/Common_Rpmlint_issues#dangling-relative-symlink says: > If your package contains both symlink and actual files, this can be safely ignored, otherwise please fix. Since we do contain the original files, we can ignore these. We can also ignore the lack of documentation (license file is pulled in by the base package) * f21-backgrounds-20.91.0.tar.xz (src.rpm) 7770ac0c65a2ee20b855fc7efca14f0d1a388acb7787fb1c7bb9fa1d5da5bbab f21-backgrounds-20.91.0.tar.xz sha512sum f21-backgrounds-20.91.0.tar.xz (upstream) 7770ac0c65a2ee20b855fc7efca14f0d1a388acb7787fb1c7bb9fa1d5da5bbab f21-backgrounds-20.91.0.tar.xz If you could answer the two comments at the top, I'll approve this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review