[Bug 1086790] Review Request: gnudos - A GNU library to help new users of the GNU system

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1086790



--- Comment #19 from Petr Šabata <psabata@xxxxxxxxxx> ---
I find the %description a little confusing -- at first I wasn't quite sure what
the difference between your "utilities" and "programs" was and kept looking for
binaries which weren't there.  Perhaps some rewording would be good.

Update the Texinfo index before the package gets uninstalled, i.e. in a %preun
section, not %postun.

Also, your Texinfo files have strange permissions (755).  Remove the executable
bits.

Next, a little subjective note -- consider making the SPEC file more readable. 
An empty line here and there won't hurt (e.g. separate the paragraphs in
%description, separate %description from other headers, separate %changelog
entries...)

Packaging aside, a question: your library is called libgnudos-1.6.so* -- this
will make developemt of software using your code fairly uncomfortable and I
don't think this is what you want.  Unless you really know why you're doing
this, consider dropping the version from the actual library name.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]