[Bug 1119369] Review Request: speedtest-cli - Command line interface for testing internet bandwidth

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1119369



--- Comment #5 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Sorry for being late.

Only 2 issues are remaining now

1) rpmlint on binary rpm is showing
speedtest-cli.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/speedtest_cli.py 0644L /usr/bin/env

=> this can be fixed by adding following in %prep, below setup line
sed -i -e '/^#!\//, 1d' *.py


2) You have written in %files
%{python2_sitelib}/speedtest_cli.*
%{python2_sitelib}/speedtest_cli-0.3.0-py2.7.egg-info/*

we need this to be changed to have directory
%{python2_sitelib}/speedtest_cli-0.3.0-py2.7.egg-info owned by this package.

which should be written as
%{python2_sitelib}/speedtest_cli.py*
%{python2_sitelib}/speedtest_cli-0.3.0-py2.7.egg-info

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]