https://bugzilla.redhat.com/show_bug.cgi?id=1121082 --- Comment #2 from František Dvořák <valtri@xxxxxxxxxx> --- 1) missing license text (some MIT variants even require to distribute it with the sources), upstream needs to be notified; the good thing is the README links to exact MIT variant [http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text] (This week I bumped to the same problem with logstasher :-), I'll submit it for review later, there were other issues yet...) 2) missing man-pages: packagers should work with upstream to add them, but it is not strictly required by guidelines [https://fedoraproject.org/wiki/Packaging:Guidelines?rd=PackagingGuidelines#Man_pages] I wrote simple man-page for clockworkd (with texts from help a README), it could be used (and maybe improved): http://scientific.zcu.cz/fedora/REVIEWS/clockworkd.1 3) you could prepare commented out exact steps in %check, for minitest I have seen this magic formula in the ruby list: ruby -Ilib -e 'Dir.glob "./test/**/*_test.rb", &method(:require)' I was able to launch the tests this way, after installing dependencies and 'gem install contests'. 4) cosmetic: timestamp of the source gem in .src.rpm should be rather 2014-07-05 curl and wget supports setting of "remote" timestamp, but it is not enabled by default [http://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps] -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review