[Bug 1128253] Review Request: gerrymander - A client API and command line tool for gerrit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1128253



--- Comment #20 from Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> ---
(In reply to Parag AN(पराग) from comment #19)
> (In reply to Bohuslav "Slavek" Kabrda from comment #17)
> > (In reply to Daniel Berrange from comment #16)
> > > (In reply to Bohuslav "Slavek" Kabrda from comment #15)
> > > > The specfile seems fine, but you should take care of the situation when
> > > > with_python3 is "0" - in this situation, /usr/bin/gerrymander wouldn't work.
> > > > I'd solve it like this (incomplete example):
> > > 
> > > Even simpler is to just delete the 'with_python3' conditional - all current
> > > Fedora releases have python3  so might as well just rely on it existing.
> > 
> > Yes, assuming the maintainer doesn't want to also put this package in EPEL
> > and keep the same specfile that he has in Fedora.
> 
> So do we need to create python-gerrymander or skip it? The script
> gerrymander points to python3 hashbang. If we think on dropping with_python3
> conditionals then drop python-gerrymander also and just package gerrymander
> and python3-gerrymander.

That is up to you. If you think people will not want to use the
python-gerrymander library with Python 2 or you don't want to maintain it, you
*don't have to* provide it.
Having said that, many people have apps written in Python 2 that are still not
compatible with Python 3, so providing both subpackages might help them with
migration and testing their apps on both Python major versions. But again, this
is your decision as a packager. You can start having just Python 3 subpackage
and add Python 2 support if someone requests it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]