[Bug 1127894] Review Request: jsap

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1127894



--- Comment #5 from Ismael Olea <ismael@xxxxxxxx> ---
(In reply to gil cattaneo from comment #4)
> (In reply to gil cattaneo from comment #2)
> > please,remove 
> > #%pom_add_dep com.martiansoftware.snip %{name}.pom
> > #%pom_add_dep com.martiansoftware.rundoc %{name}.pom
> not have sense add these libraries as build deps.

I'll remove this pom references but snip and rundoc are required for building
the documentation (manual ant task)

> javac target andsource MUST be changed in 1.5 or major (in ant build
> script/s)

Ok

(In reply to gil cattaneo from comment #2)
> please,remove 
> #%pom_add_dep com.martiansoftware.snip %{name}.pom
> #%pom_add_dep com.martiansoftware.rundoc %{name}.pom

done

> there are unneeded BR:

done

> unnecessary Requires (XMvn handled by XMvn - javapackages-*)
> [...]
done

> use:
> find . -name "*.jar" -delete
> find . -name "*.class" -delete

I choose to explicit remove existing files in order to easy detect changes in
future releases.

Here is the last revision:

http://olea.org/tmp/jsap-2.1-5.3.fc22.src.rpm
http://olea.org/tmp/jsap.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]