[Bug 1122231] Review Request: nodejs-proxy-agent - Maps proxy protocols to http.Agent implementations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1122231

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #4 from Parag AN(पराग) <panemade@xxxxxxxxx> ---

Review:

+ mock build is successful for f22.

+ rpmlint output on rpms gave
nodejs-proxy-agent.noarch: W: spelling-error Summary(en_US) http -> HTTP
nodejs-proxy-agent.noarch: W: spelling-error %description -l en_US proxying ->
propping
nodejs-proxy-agent.noarch: W: spelling-error %description -l en_US http -> HTTP
nodejs-proxy-agent.noarch: W: only-non-binary-in-usr-lib
nodejs-proxy-agent.noarch: W: dangling-symlink
/usr/lib/node_modules/proxy-agent/node_modules/pac-proxy-agent
/usr/lib/node_modules/pac-proxy-agent
nodejs-proxy-agent.noarch: W: dangling-symlink
/usr/lib/node_modules/proxy-agent/node_modules/https-proxy-agent
/usr/lib/node_modules/https-proxy-agent
nodejs-proxy-agent.noarch: W: dangling-symlink
/usr/lib/node_modules/proxy-agent/node_modules/lru-cache
/usr/lib/node_modules/lru-cache
nodejs-proxy-agent.noarch: W: dangling-symlink
/usr/lib/node_modules/proxy-agent/node_modules/socks-proxy-agent
/usr/lib/node_modules/socks-proxy-agent
nodejs-proxy-agent.noarch: W: dangling-symlink
/usr/lib/node_modules/proxy-agent/node_modules/http-proxy-agent
/usr/lib/node_modules/http-proxy-agent
nodejs-proxy-agent.src: W: spelling-error Summary(en_US) http -> HTTP
nodejs-proxy-agent.src: W: spelling-error %description -l en_US proxying ->
propping
nodejs-proxy-agent.src: W: spelling-error %description -l en_US http -> HTTP
2 packages and 0 specfiles checked; 0 errors, 12 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball    
:85a664fd213d69002873899d230dcc1f0c66b51ce7f447d5b5efde57d6bf09c6
upstream tarball
:85a664fd213d69002873899d230dcc1f0c66b51ce7f447d5b5efde57d6bf09c6

+ License "MIT" is valid and is included in README.md file as %doc

+ rest looks following packaging guidelines.


APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]