[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support & more

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1117209



--- Comment #19 from Thorsten Scherf <tscherf@xxxxxxxxxx> ---
>1. SourceURL MUST be fixed
>
>Source: %{name}.tar.gz

Has been fixed.

>2.  $RPM_OPT_FLAGS MUST be used (or rationale given why not),

Has been fixed.

>3.  SHOULD drop unused
>BuildRequires: automake

Requirement removed.

>4. SHOULD use 'install -p' flag to preserve timestamps

Has been fixed.

>5. COPYRIGHT file mentions a bunch of different licenses, none of which is GPL
>
>the source files themselves only say "See the file COPYRIGHT for licensing >information."  ugh, without clarification, we may have to conclude *all* >mentioned licenses apply, including: BSD, OpenSSL, and 2 others not mentioned >in 
>https://fedoraproject.org/wiki/Licensing
>SSLeay and OpenOSP, may need to ask fedora legal mailing list for help here,
>https://admin.fedoraproject.org/mailman/listinfo/legal
>
>(Do you want to, or would you rather I do it?)

Go ahead. Thanks.

>the OpenSDP variant looks close to "BSD with attribution" variant.  so, maybe >we can go with that for now, and use:
>
>5.  License: (BSD with attribution) and OpenSSL

License has been replaced.


Find the new package and spec here:

http://people.redhat.com/tscherf/fedora/rpms/sscep-0.5.0-3.fc20.src.rpm
http://people.redhat.com/tscherf/fedora/rpms/sscep.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]