https://bugzilla.redhat.com/show_bug.cgi?id=1127169 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: $ diff -u perl-CPAN-Reporter.spec{.old,} --- perl-CPAN-Reporter.spec.old 2014-08-06 12:05:58.000000000 +0200 +++ perl-CPAN-Reporter.spec 2014-08-20 12:25:57.000000000 +0200 @@ -45,7 +45,8 @@ BuildRequires: perl(version) BuildRequires: perl(warnings) Requires: perl(CPAN) >= 1.94 -Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) +Requires: perl(Data::Dumper) +Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) %{?perl_default_filter} %global __requires_exclude %{?__requires_exclude:__requires_exclude|}^perl\\(Win32::Job) @@ -53,17 +54,14 @@ %global __requires_exclude %__requires_exclude|^perl\\(File::HomeDir\\)$ %global __requires_exclude %__requires_exclude|^perl\\(CPAN\\) %description -The CPAN Testers project captures and analyzes detailed results from -building and testing CPAN distributions on multiple operating systems and -multiple versions of Perl. This provides valuable feedback to module -authors and potential users to identify bugs or platform compatibility -issues and improves the overall quality and value of CPAN. +CPAN::Reporter is an add-on for the CPAN.pm module to send the results of +building and testing modules to the CPAN Testers project. %prep %setup -q -n CPAN-Reporter-%{version} %build -%{__perl} Makefile.PL INSTALLDIRS=vendor +perl Makefile.PL INSTALLDIRS=vendor make %{?_smp_mflags} %install @@ -77,7 +75,7 @@ make test %files -%doc Changes CONTRIBUTING LICENSE README Todo +%doc Changes CONTRIBUTING LICENSE README Todo examples %{perl_vendorlib}/* %{_mandir}/man3/* > FIX: The description is not sufficient. It talks about CPAN Testers but not a > word about the software you package. I recommend to replace it with an excerpt > from the second paragraph of README's DESCRIPTION: %description -The CPAN Testers project captures and analyzes detailed results from -building and testing CPAN distributions on multiple operating systems and -multiple versions of Perl. This provides valuable feedback to module -authors and potential users to identify bugs or platform compatibility -issues and improves the overall quality and value of CPAN. +CPAN::Reporter is an add-on for the CPAN.pm module to send the results of +building and testing modules to the CPAN Testers project. Ok. > TODO: Replace `%{__perl}' macros with plain `perl' command. -Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) +Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) -%{__perl} Makefile.PL INSTALLDIRS=vendor +perl Makefile.PL INSTALLDIRS=vendor Ok. > TODO: Package the `examples' directory as documentation. -%doc Changes CONTRIBUTING LICENSE README Todo +%doc Changes CONTRIBUTING LICENSE README Todo examples > FIX: Run-require `perl(Data::Dumper)' (lib/CPAN/Reporter.pm:933). +Requires: perl(Data::Dumper) Ok. $ rpmlint perl-CPAN-Reporter.spec ../SRPMS/perl-CPAN-Reporter-1.2011-1.fc22.src.rpm ../RPMS/noarch/perl-CPAN-Reporter-1.2011-1.fc22.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-CPAN-Reporter-1.2011-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(Capture::Tiny) 1 perl(Carp) 1 perl(Config) 1 perl(Config::Tiny) >= 2.08 1 perl(constant) 1 perl(CPAN) >= 1.94 1 perl(CPAN::Reporter::Config) 1 perl(CPAN::Reporter::History) 1 perl(CPAN::Reporter::PrereqCheck) 1 perl(CPAN::Version) 1 perl(Data::Dumper) 1 perl(Devel::Autoflush) >= 0.04 1 perl(Exporter) 1 perl(ExtUtils::MakeMaker) >= 6.36 1 perl(Fcntl) 1 perl(File::Basename) 1 perl(File::Find) 1 perl(File::Glob) 1 perl(File::HomeDir) >= 0.58 1 perl(File::Path) 1 perl(File::Spec) >= 3.19 1 perl(File::Temp) >= 0.16 1 perl(IO::File) 1 perl(IPC::Cmd) >= 0.76 1 perl(Parse::CPAN::Meta) 1 perl(Probe::Perl) 1 perl(strict) 1 perl(Test::Reporter) >= 1.54 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 Binary requires are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-CPAN-Reporter-1.2011-1.fc22.noarch.rpm Binary dependencies resolvable. Ok. Package build in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=7430279). Ok. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review