[Bug 1131863] Review Request: perl-Module-Build-Deprecated - Collection of modules removed from Module-Build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1131863

Petr Pisar <ppisar@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> ---
Spec file changes:

$ diff -u perl-Module-Build-Deprecated.spec{.old,}
--- perl-Module-Build-Deprecated.spec.old       2014-08-20 09:32:07.000000000
+0200
+++ perl-Module-Build-Deprecated.spec   2014-08-20 12:10:08.000000000 +0200
@@ -13,7 +13,7 @@
 BuildRequires:  perl(File::Spec)
 BuildRequires:  perl(IO::Handle)
 BuildRequires:  perl(IPC::Open3)
-BuildRequires:  perl(Module::Build)
+BuildRequires:  perl(Module::Build) >= 0.3601
 BuildRequires:  perl(Module::Metadata)
 BuildRequires:  perl(parent)
 BuildRequires:  perl(strict)
@@ -23,13 +23,14 @@
 Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo
$version))
 Requires:       perl(CPAN::Meta::YAML) >= 0.002
 Requires:       perl(version) >= 0.87
+Conflicts:      perl-Module-Build < 0.42.07

 %global __requires_exclude
%{?__requires_exclude|%__requires_exclude|}perl\\(CPAN::Meta::YAML|version\\)

 %description
 This module contains a number of module that have been removed from
 Module-Build:
-Module::Build::ModuleInfo - This has been superceded by Module::Metadata
+Module::Build::ModuleInfo - This has been superseded by Module::Metadata
 Module::Build::Version - This has been replaced by version
 Module::Build::YAML - This has been replaced by CPAN::Meta::YAML


> TODO: Fix the misspelled `superceded'.
 %description
 This module contains a number of module that have been removed from
 Module-Build:
-Module::Build::ModuleInfo - This has been superceded by Module::Metadata
+Module::Build::ModuleInfo - This has been superseded by Module::Metadata
 Module::Build::Version - This has been replaced by version
 Module::Build::YAML - This has been replaced by CPAN::Meta::YAML
Ok.

> TODO: Constrain `perl(Module::Build)' build-time dependency with `>= 0.3601'
-BuildRequires:  perl(Module::Build)
+BuildRequires:  perl(Module::Build) >= 0.3601
Ok.

> FIX: This package provides the same files as perl-Module-Build < 0.42.07.
> You have to declare appropriate `Conflicts:' tag.
+Conflicts:      perl-Module-Build < 0.42.07
Ok.

$ rpmlint perl-Module-Build-Deprecated.spec
../SRPMS/perl-Module-Build-Deprecated-0.4210-1.fc22.src.rpm
../RPMS/noarch/perl-Module-Build-Deprecated-0.4210-1.fc22.noarch.rpm 
perl-Module-Build-Deprecated.src: W: spelling-error %description -l en_US
ModuleInfo -> Module Info, Module-info, Modulation
perl-Module-Build-Deprecated.src: W: spelling-error %description -l en_US
Metadata -> Meta data, Meta-data, Metatarsal
perl-Module-Build-Deprecated.noarch: W: spelling-error %description -l en_US
ModuleInfo -> Module Info, Module-info, Modulation
perl-Module-Build-Deprecated.noarch: W: spelling-error %description -l en_US
Metadata -> Meta data, Meta-data, Metatarsal
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
rpmlint is Ok.

Package builds in F22
(http://koji.fedoraproject.org/koji/taskinfo?taskID=7430245). Ok.

Resolution: Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]