https://bugzilla.redhat.com/show_bug.cgi?id=1127169 --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are usable. Ok. Source archive is original (SHA-256: 0154f3cf6af5f20002fea34ae3b69a0300dcfc52000fea729aac4a3fa91f08fb) Ok. License verified from README, LICENSE, lib/CPAN/Reporter.pm, lib/CPAN/Reporter/PrereqCheck.pm, lib/CPAN/Reporter/History.pm, lib/CPAN/Reporter/FAQ.pm, lib/CPAN/Reporter/Config.pm, lib/CPAN/Reporter/API.pm. Ok. Summary verified from README. Ok. FIX: The description is not sufficient. It talks about CPAN Testers but not a word about the software you package. I recommend to replace it with an excerpt from the second paragraph of README's DESCRIPTION: CPAN::Reporter is an add-on for the CPAN.pm module to send the results of building and testing modules to the CPAN Testers project. TODO: Replace `%{__perl}' macros with plain `perl' command. TODO: Package the `examples' directory as documentation. No XS code, noarch BuildArch is Ok. All build-time dependencies are specified. Ok. (Upstream declares all dependencies very thoroughly. That's scarce phenomenon. Maybe it's because this software is used to exhibit tests so the upstream recognizes how important is to handle the dependencies very carefully :) All tests pass. Ok. $ rpmlint perl-CPAN-Reporter.spec ../SRPMS/perl-CPAN-Reporter-1.2011-1.fc22.src.rpm ../RPMS/noarch/perl-CPAN-Reporter-1.2011-1.fc22.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-CPAN-Reporter-1.2011-1.fc22.noarch.rpm drwxr-xr-x 2 root root 0 Aug 20 09:27 /usr/share/doc/perl-CPAN-Reporter -rw-r--r-- 1 root root 3402 Mar 16 22:28 /usr/share/doc/perl-CPAN-Reporter/CONTRIBUTING -rw-r--r-- 1 root root 44680 Mar 16 22:28 /usr/share/doc/perl-CPAN-Reporter/Changes -rw-r--r-- 1 root root 11500 Mar 16 22:28 /usr/share/doc/perl-CPAN-Reporter/LICENSE -rw-r--r-- 1 root root 7355 Mar 16 22:28 /usr/share/doc/perl-CPAN-Reporter/README -rw-r--r-- 1 root root 4588 Mar 16 22:28 /usr/share/doc/perl-CPAN-Reporter/Todo -rw-r--r-- 1 root root 4854 Aug 20 09:21 /usr/share/man/man3/CPAN::Reporter.3pm.gz -rw-r--r-- 1 root root 3698 Aug 20 09:21 /usr/share/man/man3/CPAN::Reporter::API.3pm.gz -rw-r--r-- 1 root root 5447 Aug 20 09:21 /usr/share/man/man3/CPAN::Reporter::Config.3pm.gz -rw-r--r-- 1 root root 3771 Aug 20 09:21 /usr/share/man/man3/CPAN::Reporter::FAQ.3pm.gz -rw-r--r-- 1 root root 3111 Aug 20 09:21 /usr/share/man/man3/CPAN::Reporter::History.3pm.gz -rw-r--r-- 1 root root 2704 Aug 20 09:21 /usr/share/man/man3/CPAN::Reporter::PrereqCheck.3pm.gz drwxr-xr-x 2 root root 0 Aug 20 09:21 /usr/share/perl5/vendor_perl/CPAN drwxr-xr-x 2 root root 0 Aug 20 09:21 /usr/share/perl5/vendor_perl/CPAN/Reporter -rw-r--r-- 1 root root 54772 Mar 16 22:28 /usr/share/perl5/vendor_perl/CPAN/Reporter.pm -rw-r--r-- 1 root root 4934 Mar 16 22:28 /usr/share/perl5/vendor_perl/CPAN/Reporter/API.pm -rw-r--r-- 1 root root 31486 Mar 16 22:28 /usr/share/perl5/vendor_perl/CPAN/Reporter/Config.pm -rw-r--r-- 1 root root 4361 Mar 16 22:28 /usr/share/perl5/vendor_perl/CPAN/Reporter/FAQ.pm -rw-r--r-- 1 root root 12877 Mar 16 22:28 /usr/share/perl5/vendor_perl/CPAN/Reporter/History.pm -rw-r--r-- 1 root root 7822 Mar 16 22:28 /usr/share/perl5/vendor_perl/CPAN/Reporter/PrereqCheck.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-CPAN-Reporter-1.2011-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(Capture::Tiny) 1 perl(Carp) 1 perl(Config) 1 perl(Config::Tiny) >= 2.08 1 perl(constant) 1 perl(CPAN) >= 1.94 1 perl(CPAN::Reporter::Config) 1 perl(CPAN::Reporter::History) 1 perl(CPAN::Reporter::PrereqCheck) 1 perl(CPAN::Version) 1 perl(Devel::Autoflush) >= 0.04 1 perl(Exporter) 1 perl(ExtUtils::MakeMaker) >= 6.36 1 perl(Fcntl) 1 perl(File::Basename) 1 perl(File::Find) 1 perl(File::Glob) 1 perl(File::HomeDir) >= 0.58 1 perl(File::Path) 1 perl(File::Spec) >= 3.19 1 perl(File::Temp) >= 0.16 1 perl(IO::File) 1 perl(IPC::Cmd) >= 0.76 1 perl(Parse::CPAN::Meta) 1 perl(Probe::Perl) 1 perl(strict) 1 perl(Test::Reporter) >= 1.54 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 FIX: Run-require `perl(Data::Dumper)' (lib/CPAN/Reporter.pm:933). $ rpm -q --provides -p ../RPMS/noarch/perl-CPAN-Reporter-1.2011-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(CPAN::Reporter) = 1.2011 1 perl(CPAN::Reporter::API) = 1.2011 1 perl(CPAN::Reporter::Config) = 1.2011 1 perl(CPAN::Reporter::FAQ) = 1.2011 1 perl(CPAN::Reporter::History) = 1.2011 1 perl(CPAN::Reporter::PrereqCheck) = 1.2011 1 perl-CPAN-Reporter = 1.2011-1.fc22 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-CPAN-Reporter-1.2011-1.fc22.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=7429842). Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' items, consider fixing `TODO' items, and provide new spec file. Resolution: NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review