https://bugzilla.redhat.com/show_bug.cgi?id=1128253 Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bkabrda@xxxxxxxxxx --- Comment #15 from Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> --- It makes sense for the main gerrymander package to depend *either* on python-gerrymander *or* python3-gerrymander, so that the users just install "gerrymander" and don't care about the dependencies. It however wouldn't make sense to me to install *both* python-gerrymander *and* python3-gerrymander - /usr/bin/gerrymander can only import one, anyway. The specfile seems fine, but you should take care of the situation when with_python3 is "0" - in this situation, /usr/bin/gerrymander wouldn't work. I'd solve it like this (incomplete example): # in the main package %if 0%{with_python3} Requires: python3-gerrymander %else Requires: python-gerrymander %endif # in prep %if 0%{with_python3} # make sure that hashbang points to /usr/bin/python3 explicitly %else # make sure that hashbang points to /usr/bin/python2 explicitly %endif Hope this makes sense. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review