https://bugzilla.redhat.com/show_bug.cgi?id=1130617 --- Comment #5 from Jiri Popelka <jpopelka@xxxxxxxxxx> --- Updated: Spec URL: https://jpopelka.fedorapeople.org/kea.spec SRPM URL: https://jpopelka.fedorapeople.org/kea-0.9-0.3.beta1.fc20.src.rpm (In reply to Florian "der-flo" Lehner from comment #4) > ===== MUST items ===== > [!]: License file installed when any subpackage combination is installed. > > ---> The file, containing the text of the license, must be included in > %doc > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text It is: # rpm -qd kea-libs /usr/share/doc/kea/COPYING /usr/share/doc/kea/LICENSE_1_0.txt > [!]: %build honors applicable compiler flags or justifies otherwise. > I just was thinking about something like: > CFLAGS="%{?optflags}" \ > LDFLAGS="%{?__global_ldflags}" \ > make %{?_smp_mflags} In build.log you can see that these flags are already used, so I don't get what's the use case of the above code: CXXFLAGS: -O2 -g -pipe -Wall -Werror=format-security Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic KEA_CXXFLAGS: -Wall -Wextra -Wnon-virtual-dtor -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -Werror -fPIC LDFLAGS: -Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld > ===== SHOULD items ===== > [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. > ---> Please add some information added > [!]: Packages should try to preserve timestamps of original installed files. > ---> Please add the -p to install to preserve timestamps added -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review