[Bug 1122239] Review Request: nodejs-socks-proxy-agent - A SOCKS (v4a) proxy http.Agent implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1122239

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #3 from Parag AN(पराग) <panemade@xxxxxxxxx> ---


Review:

+ mock build is successful for f22.

+ rpmlint output on rpms gave
nodejs-socks-proxy-agent.noarch: W: spelling-error Summary(en_US) http -> HTTP
nodejs-socks-proxy-agent.noarch: W: spelling-error %description -l en_US http
-> HTTP
nodejs-socks-proxy-agent.noarch: W: spelling-error %description -l en_US https
-> HTTP
nodejs-socks-proxy-agent.noarch: W: spelling-error %description -l en_US ws ->
es, w, s
nodejs-socks-proxy-agent.noarch: W: only-non-binary-in-usr-lib
nodejs-socks-proxy-agent.noarch: W: dangling-symlink
/usr/lib/node_modules/socks-proxy-agent/node_modules/rainbowsocks
/usr/lib/node_modules/rainbowsocks
nodejs-socks-proxy-agent.noarch: W: dangling-symlink
/usr/lib/node_modules/socks-proxy-agent/node_modules/agent-base
/usr/lib/node_modules/agent-base
nodejs-socks-proxy-agent.noarch: W: dangling-symlink
/usr/lib/node_modules/socks-proxy-agent/node_modules/extend
/usr/lib/node_modules/extend
nodejs-socks-proxy-agent.src: W: spelling-error Summary(en_US) http -> HTTP
nodejs-socks-proxy-agent.src: W: spelling-error %description -l en_US http ->
HTTP
nodejs-socks-proxy-agent.src: W: spelling-error %description -l en_US https ->
HTTP
nodejs-socks-proxy-agent.src: W: spelling-error %description -l en_US ws -> es,
w, s
2 packages and 0 specfiles checked; 0 errors, 12 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball    
:4b52f86453d1f37c91fb5e7db19a3be0fee47bfa9e6fe15b833f4f8ee8552c6f
upstream tarball
:4b52f86453d1f37c91fb5e7db19a3be0fee47bfa9e6fe15b833f4f8ee8552c6f

+ License "MIT" is valid and is included in README.md file as %doc

+ rest looks following packaging guidelines.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]