[Bug 1126459] Review Request: libqqwing - library for sudoku generation and solving

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1126459



--- Comment #8 from Kalev Lember <kalevlember@xxxxxxxxx> ---
This looks great to me, thanks!


Two very minor nits:

> %description    devel
> The libqqwing-devel package contains libraries and header files for
> developing applications that use libqqwing.

The description needs updating after the libqqwing -> qqwing rename. Could use
the %{name} macro here since it semantically refers to the base package's name.

> %{_mandir}/man1/qqwing.1.gz

Would be better to use a glob here to make sure this line works when the man
page compression used by rpmbuild gets changed. Something like:

%{_mandir}/man1/qqwing.1*

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]