https://bugzilla.redhat.com/show_bug.cgi?id=1130617 --- Comment #3 from Jiri Popelka <jpopelka@xxxxxxxxxx> --- Thanks for the review ! Spec URL: https://jpopelka.fedorapeople.org/kea.spec SRPM URL: https://jpopelka.fedorapeople.org/kea-0.9-0.2.beta1.fc20.src.rpm (In reply to Florian "der-flo" Lehner from comment #2) > [ ] Package does not build > ---> http://koji.fedoraproject.org/koji/taskinfo?taskID=7340518 It was failing only for armv7, which should be OK now: http://koji.fedoraproject.org/koji/taskinfo?taskID=7406293 > [ ] Please create a subpackage for documentation See below > [ ] The %doc is missing in %files I don't use %doc to install documentation, see https://fedoraproject.org/wiki/Packaging_tricks#As_part_of_the_staged_install > [ ] Please replace cp with install in the spec-File done > ===== MUST items ===== > [x]: License file installed when any subpackage combination is installed. This was actually [!], but I moved the COPYING & LICENSE_1_0.txt into kea-libs which is always installed. > ---> COPYING is missing in %doc in the %files-section See above > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/share/doc/kea fixed > [!]: %build honors applicable compiler flags or justifies otherwise. > > ---> Please use build flags I don't override them. I use 'make %{?_smp_mflags}' per https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make > [!]: Changelog in prescribed format. > > ---> Why do you use this kind of release-number? see https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages > [!]: Package does not generate any conflict. Do you see any ? > [!]: Package is not known to require an ExcludeArch tag. > > ---> http://koji.fedoraproject.org/koji/taskinfo?taskID=7340518 > Package doesn't build so far. Should be OK now, see above. > [!]: Large documentation must go in a -doc subpackage. Large could be size > (~1MB) or number of files. > Note: Documentation size is 972800 bytes in 15 files. I still think this is not a 'large' documentation and would rather keep it in the same package. This dhcp/dhcpv6 implementation is completely new and most users will need the documentation anyway. Maybe later if it grows. > ===== SHOULD items ===== > Generic: > [!]: Package should compile and build into binary rpms on all supported > architectures. > ---> http://koji.fedoraproject.org/koji/taskinfo?taskID=7340518 Should be fixed, see above. > [!]: %check is present and all tests pass. Should be OK now. > ===== EXTRA items ===== > Generic: > [!]: Package should not use obsolete m4 macros > Note: Some obsoleted macros found, see the attachment. > See: https://fedorahosted.org/FedoraReview/wiki/AutoTools fixed > [!]: Large data in /usr/share should live in a noarch subpackage if package > is > arched. > Note: Arch-ed rpms have a total of 1044480 bytes in /usr/share > > ---> Please add a subpackage for docs See above. > Rpmlint > ------- > kea.x86_64: E: zero-length /var/lib/kea/kea-leases4.csv > kea.x86_64: E: zero-length /var/lib/kea/kea-leases6.csv described in comment #0 > kea.x86_64: E: executable-marked-as-config-file /etc/kea/dhcp-ddns.json > kea.x86_64: E: script-without-shebang /etc/kea/dhcp-ddns.json fixed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review