[Bug 823679] Review Request: python-pdfminer - PDF data parsing library and tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=823679



--- Comment #10 from Lubomir Rintel <lkundrak@xxxxx> ---
0.) rpmlint unhappy:

python-pdfminer.src:17: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab:
line 17)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

1.) You don't need to quote your name with single quotes in changelog:


* Sat Aug 16 2014 'Ben Rosser' <rosser.bjr@xxxxxxxxx> 20140328-0

2.) Please move the files only after actual install in %{buildroot}.

This makes %install non-idempotent and thus breaks short-circuit of install
phase (rpmbuild -bi --short-circuit).

%install
...
# Rename the python scripts to get rid of the *.py suffix
mv build/scripts-2.7/dumppdf.py build/scripts-2.7/dumppdf
mv build/scripts-2.7/pdf2txt.py build/scripts-2.7/pdf2txt
mv build/scripts-2.7/latin2ascii.py build/scripts-2.7/latin2ascii

3.) The initial release number should be >= 1.

Release numbers < 1 are reserved to pre-release snapshots.

Release:        0%{?dist}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]