[Bug 1127894] Review Request: jsap

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1127894

gil cattaneo <puntogil@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |puntogil@xxxxxxxxx



--- Comment #2 from gil cattaneo <puntogil@xxxxxxxxx> ---
please,remove 
#%pom_add_dep com.martiansoftware.snip %{name}.pom
#%pom_add_dep com.martiansoftware.rundoc %{name}.pom
or create some template pom for both packages
e.g.


<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
    <modelVersion>4.0.0</modelVersion>

    <groupId>com.martiansoftware.@PROJECT@</groupId>
    <artifactId>@PROJECT@</artifactId>
    <version>@VERSION@</version>
    <packaging>jar</packaging>
</project>

there are unneeded BR:
BuildRequires:  java-devel >= 1:1.6.0
BuildRequires:  maven-local
you can use only
BuildRequires:  javapackages-tools
or better
BuildRequires:  javapackages-local

unnecessary Requires (XMvn handled by XMvn - javapackages-*)
Requires:       java-headless >= 1:1.6.0
Requires:       javapackages-tools
also for sub package javadoc
Requires:       %{name} = %{version}-%{release}
Requires:       javapackages-tools

this should be a bug in XMvn, please contact mizdebsk@xxxxxxxxxx for more info
%dir /usr/share/maven-poms/%{name}/

please fix unowner %dir /usr/share/java/%{name}/

please use %dir %{_javadir}/%{name}/ instead of %dir /usr/share/java/%{name}/

"Group:" tag is no longer necessary.

please, cleanup spec file:
remove %define * (unused)


use:
find . -name "*.jar" -delete
find . -name "*.class" -delete


You can make maven install the javadocs by passing -J to mvn_install
%mvn_install -J javadoc
And then in the files section, you can have:
%files javadoc -f .mfiles-javadoc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]