[Bug 1129630] Review Request: riemann-c-client - The riemann C client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1129630



--- Comment #6 from Peter Czanik <pczanik@xxxxxxxxxxxxxx> ---
The upstream developer checked the problem and recommended to use github
generated sources instead of "make dist" generated sources and run "autoreconf
-i" as part of the package building process. According to him, Fedora uses a
modified libtool, which behaves differently than the one on his system.

Is such a change OK? (previously I was told, that the use of autotools is
discouraged) Here is a diff, how the spec file would change from the previously
posted version:

[czanik@localhost riemann-c-client]$ diff -u riemann-c-client.spec.old
riemann-c-client.spec
--- riemann-c-client.spec.old    2014-08-15 10:11:58.280937822 +0200
+++ riemann-c-client.spec    2014-08-15 11:26:49.345601699 +0200
@@ -6,15 +6,17 @@

 Name:        riemann-c-client
 Version:    1.2.1
-Release:    3%{?dist}
+Release:    4%{?dist}
 Summary:    The riemann C client
 License:    GPLv2
 Url:        https://github.com/algernon/riemann-c-client
-Source:       
https://github.com/algernon/riemann-c-client/releases/download/riemann-c-client-%{version}/riemann-c-client-%{version}.tar.xz
+Source:       
https://github.com/algernon/riemann-c-client/releases/download/riemann-c-client-%{version}/riemann-c-client-%{version}.tar.gz
 BuildRequires:    pkgconfig
 BuildRequires:    protobuf-c-devel
 BuildRequires:    json-c-devel
-BuildRequires:    chrpath
+BuildRequires:    autoconf
+BuildRequires:    automake
+BuildRequires:    libtool

 %description
 This is a C client library for the Riemann monitoring system, providing a
@@ -31,9 +33,10 @@
 This package provides files necessary for riemann-c-client development.

 %prep
-%setup -q
+%setup -q -n riemann-c-client-riemann-c-client-%{version}

 %build
+autoreconf -i
 %configure \
     --disable-static \
     --disable-rpath
@@ -43,8 +46,6 @@
 %install
 make DESTDIR=${RPM_BUILD_ROOT} install

-chrpath --delete $RPM_BUILD_ROOT%{_bindir}/riemann-client
-
 rm %{buildroot}/%{_libdir}/libriemann-client.la

 %post -p /sbin/ldconfig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]