Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Workflow - Simple, flexible system to implement workflows Alias: perl-Workflow https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231758 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-04-24 05:13 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url e9c25c357b0e2a62fa91493b818a538f Workflow-0.26.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test t/action...........................ok t/action_field.....................ok t/action_null......................ok t/base.............................ok t/condition........................ok t/condition_evaluate...............ok t/config...........................Use of uninitialized value in numeric eq (==) at t/config.t line 41. ok t/context..........................ok t/exception........................ok t/factory..........................ok t/factory_subclass.................ok t/history..........................ok t/persister_dbi....................Use of uninitialized value in concatenation (.) or string at /usr/lib/perl5/vendor_perl/5.8.8/DBD/Mock.pm line 531. ok t/persister_dbi_extra_data.........ok t/persister_file...................ok t/persister_random_id..............ok t/persister_spops..................skipped all skipped: SPOPS not installed t/persister_uuid...................skipped all skipped: Data::UUID not installed t/state............................ok t/validator........................ok t/validator_has_required_field.....ok t/validator_in_enumerated_type.....ok t/validator_matches_date_format....ok t/workflow.........................Use of uninitialized value in concatenation (.) or string at /usr/lib/perl5/vendor_perl/5.8.8/DBD/Mock.pm line 531. ok All tests successful, 2 tests skipped. Files=24, Tests=192, 10 wallclock secs ( 7.04 cusr + 0.79 csys = 7.83 CPU) + Provides: perl(Workflow) perl(Workflow::Action) perl(Workflow::Action::InputField) perl(Workflow::Action::Null) perl(Workflow::Base) perl(Workflow::Condition) perl(Workflow::Condition::Evaluate) perl(Workflow::Condition::HasUser) perl(Workflow::Config) perl(Workflow::Config::Perl) perl(Workflow::Config::XML) perl(Workflow::Context) perl(Workflow::Exception) perl(Workflow::Factory) perl(Workflow::History) perl(Workflow::Persister) perl(Workflow::Persister::DBI) perl(Workflow::Persister::DBI::AutoGeneratedId) perl(Workflow::Persister::DBI::ExtraData) perl(Workflow::Persister::DBI::SequenceId) perl(Workflow::Persister::File) perl(Workflow::Persister::RandomId) perl(Workflow::Persister::SPOPS) perl(Workflow::Persister::UUID) perl(Workflow::State) perl(Workflow::Validator) perl(Workflow::Validator::HasRequiredField) perl(Workflow::Validator::InEnumeratedType) perl(Workflow::Validator::MatchesDateFormat) + Requires: perl(:MODULE_COMPAT_5.8.8) perl(DBI) perl(Data::Dumper) perl(Data::UUID) perl(DateTime) perl(DateTime::Format::Strptime) perl(Exception::Class) perl(File::Spec::Functions) perl(Log::Log4perl) perl(Safe) perl(Workflow) perl(Workflow::Action) perl(Workflow::Action::InputField) perl(Workflow::Condition) perl(Workflow::Condition::Evaluate) perl(Workflow::Config) perl(Workflow::Context) perl(Workflow::Exception) perl(Workflow::Factory) perl(Workflow::History) perl(Workflow::Persister) perl(Workflow::Persister::DBI::AutoGeneratedId) perl(Workflow::Persister::DBI::SequenceId) perl(Workflow::Persister::RandomId) perl(Workflow::State) perl(Workflow::Validator) perl(Workflow::Validator::HasRequiredField) perl(XML::Simple) perl(base) perl(constant) perl(strict) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review