Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vegastrike-data - Data files for Vega Strike https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233783 peter@xxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From peter@xxxxxxxxxxxxxxxx 2007-04-23 21:12 EST ------- (In reply to comment #2) > Yes, I saw those warnings before submission myself too, but I've deliberately > ignored them, as I think these empty files might still be needed / usefull. That's OK, then. > > (2) As-is, it seems to include its own locally-modified copy of various Python > > modules (modules/builtin/). A brief perusal of the diff between the included > > python modules and the system copies of them shows mostly variable renaming and > > similar generally-insignificant changes. > > > > Good catch, removed. Thanks! :] > Notice these are data files, not user docs, and I think the game might actually > expect / depend on them being ISO-8859, so I've kept these as is. That's acceptable, then; though it should be brought to the attention of the upstream devs. UTF-8 is so much nicer than having to worry about codepages and stuff. ;) > These are just 2 of a long list of in game fake advertisements, which are there > to create a certain atmosphere. I personally find the ones about guns and > joining the army / the ones promoting militarism much more offensive then the 2 > you name. IOW this is pretty subjective. Removing any of them feels like > applying censorship to me, and lets please not go there unless things are > clearly illegal or really bad taste / inappropriate I agree. Someone from FESCo would need to make the final yea or nay, though if it came down to it. OK as-is. > Most of these were in the builtin dir, the remaining 2 are really scripts meant > to be executed stand alone, and thus should be executable. > Thanks for the clarification, then. With the fixes applied as you've mentioned, vegastrike-data 0.4.3-2 is APPROVED. > I only updated the specfile as the sources didn't change and it takes eons to > upload it with my link. Highly understandable - it takes eons to download it, even. ^_^ Though that's a problem with most large game-data packages. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review