[Bug 1129691] Review Request: libde265 - Open H.265 video codec implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1129691

Antonio Trande <anto.trande@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anto.trande@xxxxxxxxx



--- Comment #2 from Antonio Trande <anto.trande@xxxxxxxxx> ---
Hi Joachim.

1) Using these tools to build 'configure' scripts and 'Makefiles' is
inadvisable. This software already has own scripts, if they are built by too
old tools, please, 

  1- point out this to the upstream

 or 

  2- perform 'autogen.sh' outside RPM packaging then apply a patch to update
the  configure scripts and Makefile.ins


2) If you don't want to build 'dec265 decoder program' and 'sherlock265 visual
inspection program', you can use --disable-dec265  --disable-sherlock265
options; better if you add --disable-silent-rules option, too.

Then, probably, you don't need anymore of the lines 
rm -f %{buildroot}%{_bindir}/dec265
rm -f %{buildroot}%{_bindir}/sherlock265

3) %clean section and '%defattr(-,root,root,-)' are useless.
   Unless this software will be packaged for systems < EPEL6

4) Requires: %{name} = %{version}-%{release} 
   must be arched
   Requires: %{name}%{?_isa} = %{version}-%{release}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]