[Bug 1128100] Review Request: python-markups - A wrapper around various text markups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1128100

Christopher Meng <i@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review+              |



--- Comment #9 from Christopher Meng <i@xxxxxxxx> ---
I'm sorry, you all didn't realize the essential issues:

1. %global with_python3 1
%global srcname Markups

Name:           python-markups
Version:        0.5.0
Release:        3%{?dist}
Summary:        A wrapper around various text markups

License:        BSD
URL:            https://pypi.python.org/pypi/Markups
Source0:       
https://pypi.python.org/packages/source/M/%{srcname}/%{srcname}-%{version}.tar.gz

BuildArch:      noarch
BuildRequires:  python2-devel
BuildRequires:  python-setuptools
BuildRequires:  python-markdown
BuildRequires:  python-docutils
BuildRequires:  python-textile
Requires:       python-markdown
Requires:       python-docutils
Requires:       python-textile
%if 0%{?with_python3}
BuildRequires:  python3-devel
BuildRequires:  python3-setuptools
BuildRequires:  python3-markdown
BuildRequires:  python3-docutils
BuildRequires:  python3-textile
Requires:       python3-markdown
Requires:       python3-docutils
Requires:       python3-textile
%endif

Yeah yeah, when you enable python3 build the python-markup will have python3
dependencies in itself whereas python3-markup has no python3 deps.

Please, move the %if 0%{?with_python3}...%endif to underneath the python3
%package.

2. rm -rf %{buildroot}/%{python3_sitelib}/*.egg-info

Please, I don't know what you are doing here, doing this will cause FTBFS of
other packages. Volker is right, he told you to

(In reply to Volker Fröhlich from comment #2)
> Please delete the egg-info directory in the prep section. 

Which means the python eggs shipped in the tarball should be deleted _before_
%build, not to let you delete those generated by %build.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]