https://bugzilla.redhat.com/show_bug.cgi?id=1129630 --- Comment #3 from Christopher Meng <i@xxxxxxxx> --- Have been tracking this for months. 1. Requires: %{name} = %{version} Requires: protobuf-c-devel https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package Thus: Requires: %{name}%{?_isa} = %{version}-%{release} Requires: protobuf-c-devel%{?_isa} Just out of curiousity, why not add json-devel here as well? 2. %configure \ --disable-static As you only use one option here, no need to use \. 3. %post /sbin/ldconfig %postun /sbin/ldconfig -> %post -p /sbin/ldconfig %postun -p /sbin/ldconfig 4. In Fedora, %dir %{_includedir}/riemann/ %dir %{_includedir}/riemann/proto/ %{_includedir}/riemann/*.h %{_includedir}/riemann/proto/*.h Can be: %{_includedir}/riemann/ That's when you want to use a simpler way, not when you want to explicitly list files. 5. Changelog invalid: http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs 6. %setup -q -n riemann-c-client-%{version} -> %setup -q 7. Source tag without full link. 8. Drop Group tag. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review