https://bugzilla.redhat.com/show_bug.cgi?id=1129630 Ralf Corsepius <rc040203@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rc040203@xxxxxxxxxx --- Comment #1 from Ralf Corsepius <rc040203@xxxxxxxxxx> --- This package needs quite some amount of work: * Many rpm anachronisms inside of this spec, which are not neccessary with modern rpm (BuildRoot, %defattr etc.) * The BR: xz is for the xz-compressed tarball? Rpm knows to handle xz-compressed tarballs for quite some time. * The package is not split into *-devel and <main> package properly. Only the *.so belongs into *devel, *.so.* into <main> * Don't ship *.la. * Feel strongly encouraged to not ship static libs (%configure --disable-static) If you insist on doing so, put them into a *-static subpackage. * The package seems to contain a test suite but doesn't exercise it? Is there a special reason for not doing so? * The %attr's are unnecessary and partially wrong (rpm warns about it). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review