[Bug 1086406] Review Request: python-nose-testconfig - Test configuration plugin for nosetests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1086406



--- Comment #5 from David Shea <dshea@xxxxxxxxxx> ---
(In reply to Antonio Trande from comment #4)
> - The directories
> /usr/lib/python3.4/site-packages,/usr/lib/python3.4/site-packages/
> __pycache__,
>   /usr/lib/python3.4 are owned by python3-* packages.

I'm not sure what you're trying to say here. The python3-nose-testconfig does
not own these directories, nor should it, since they are common to all python3
packages and owned by python3-libs.
$ rpm -q --filesbypkg -p
RPMS/noarch/python3-nose-testconfig-0.9-2.fc22.noarch.rpm
python3-nose-testconfig  
/usr/lib/python3.4/site-packages/__pycache__/testconfig.cpython-34.pyc
python3-nose-testconfig  
/usr/lib/python3.4/site-packages/__pycache__/testconfig.cpython-34.pyo
python3-nose-testconfig  
/usr/lib/python3.4/site-packages/nose_testconfig-0.9-py3.4.egg-info
python3-nose-testconfig  
/usr/lib/python3.4/site-packages/nose_testconfig-0.9-py3.4.egg-info/PKG-INFO
python3-nose-testconfig  
/usr/lib/python3.4/site-packages/nose_testconfig-0.9-py3.4.egg-info/SOURCES.txt
python3-nose-testconfig  
/usr/lib/python3.4/site-packages/nose_testconfig-0.9-py3.4.egg-info/dependency_links.txt
python3-nose-testconfig  
/usr/lib/python3.4/site-packages/nose_testconfig-0.9-py3.4.egg-info/entry_points.txt
python3-nose-testconfig  
/usr/lib/python3.4/site-packages/nose_testconfig-0.9-py3.4.egg-info/top_level.txt
python3-nose-testconfig   /usr/lib/python3.4/site-packages/testconfig.py
python3-nose-testconfig   /usr/share/doc/python3-nose-testconfig
python3-nose-testconfig   /usr/share/doc/python3-nose-testconfig/ACKS
python3-nose-testconfig   /usr/share/doc/python3-nose-testconfig/LICENSE-2.0
python3-nose-testconfig   /usr/share/doc/python3-nose-testconfig/TODO
python3-nose-testconfig   /usr/share/doc/python3-nose-testconfig/index.txt

$ rpm -qf /usr/lib/python3.4/site-packages/
python3-libs-3.4.1-12.fc21.x86_64



> - This package contains a License file separated from upstream. This issue
> has been already pointed out to the developer. 
> (https://bitbucket.org/jnoller/nose-testconfig/issue/10/add-licensing-
> information-to-python-file)
> 
>   Please, leave a comment just above Source1 tag.

Will do.

> 
> - Why do you not define a 'with_python3' conditional macro like that adviced
> on Packaging guidelines for Python code?  
>   https://fedoraproject.org/wiki/Packaging:Python#Building_more_than_once

Because this macro is pointless. As it states in that very section, "Once
python 3 support has been added to a package, you must leave it enabled." And
since it's a small noarch package, building the python3 support doesn't even
take particularly long, so there's no point in ever turning it off.

Even adding it just with EPEL support in mind would necessitate further changes
once python3 is added to EPEL-7.

New package with the Source1 comment:

Spec URL:
https://dshea.fedorapeople.org/python-nose-testconfig/0.9-3/python-nose-testconfig.spec
SRPM URL:
https://dshea.fedorapeople.org/python-nose-testconfig/0.9-3/python-nose-testconfig-0.9-3.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]