https://bugzilla.redhat.com/show_bug.cgi?id=1128335 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hdegoede@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |hdegoede@xxxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Hans de Goede <hdegoede@xxxxxxxxxx> --- Full review done: Good: ===== - rpmlint checks return: libdom-devel.x86_64: W: only-non-binary-in-usr-lib 4 packages and 0 specfiles checked; 0 errors, 1 warnings. -This is just rpmlint showing a new level of mindlessness even for rpmlint, can be safely ignored - package meets naming guidelines - package meets packaging guidelines - license (MIT) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on F-21 (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r and isa Needs work: ======== - Nothing APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review