[Bug 1128378] Review Request: cv - Coreutils Viewer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1128378



--- Comment #9 from Christopher Meng <i@xxxxxxxx> ---
1. Please, unset %global _hardened_build 1, I don't know why you prefer adding
this to all packages.

2. LDFLAGS still not set:

cc -Wall cv.o sizes.o hlist.o -o cv -lncurses -lm

In your spec:

LDFLAGS="%{?__global_ldflags}"    \

Ooops, upstream uses LFLAGS XD.

3. mkdir -p %{buildroot}%{_bindir}
install -pm 0755 %{name} %{buildroot}%{_bindir}/%{name}

If you read the makefile carefully, you can try "%make_install
PREFIX=%{buildroot}%{_prefix}". In the next version, use "%make_install
PREFIX=%{_prefix}".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]