[Bug 1128378] Review Request: cv - Coreutils Viewer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1128378

Ralf Corsepius <rc040203@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203@xxxxxxxxxx



--- Comment #4 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
Some remarks:

1. I do not see any reason why this package should be built hardened.
=> Remove "%global _hardened_build 1"

2. Passing LDFLAGS is not required.
=> Remove LDFLAGS+="%{?__global_ldflags}" 

3.  Package does not honor CFLAGS:

gcc -g -Wall -D_FILE_OFFSET_BITS=64 -c cv.c
gcc -g -Wall -D_FILE_OFFSET_BITS=64 -c sizes.c
gcc -g -Wall -D_FILE_OFFSET_BITS=64 -c hlist.c
gcc -Wall cv.o sizes.o hlist.o -o cv -lncurses -lm  

This package uses simple and naive Makefile, so you need to override CFLAGS
from the environment or make's command-line.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]