https://bugzilla.redhat.com/show_bug.cgi?id=1118267 --- Comment #3 from Nicolas Chauvet (kwizart) <kwizart@xxxxxxxxx> --- Thx for looking into this review. I will change the name for aces-container and add Provides: aces_container = v-r (same for devel). That been said whereas using %{name} macro everywhere is fine, one must make the difference between the projet name and the package name. if there is a need for foo-compat package forked from earlier foo package, there is no reason to rename the patches from foo to foo-compat. This is a thin difference, but that's also the difference between proper/improper usage of the %{name} macro. So I admit to use the %{name} macro for a tarball name when possible provided that the package name change less often. But the way I generate patches with gendiff and c&p the resulting output to the spec file will requires an additional step to change the name to the macro. I don't usually see the benefit for the aforementioned reason. Are you fine with the rational? do you plan to take the review ? Do you plan to do a formal review before for me to update the package ? Thx again for looking into this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review