Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: hardlink https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225881 wolfy@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED AssignedTo|jnovy@xxxxxxxxxx |wolfy@xxxxxxxxxxxxxxxxxx Flag|fedora-review-, |fedora-review+ |needinfo?(roozbeh@xxxxxxxxxx| |nfo) | ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-04-23 09:34 EST ------- The theory says that Source0 should be a full (downloadable) URL. Given the fact that upstream is .. hugh.. you, I think that you could just add a comment with instructions on how to get (a specific version) from CVS. GOOD rpmlint checks: Source RPM: W: hardlink unversioned-explicit-obsoletes kernel-utils rpmlint of hardlink: W: hardlink obsolete-not-provided kernel-utils --> seems correct, the kernel-utils package has been replaced by a lot of other smaller packages which include all the utilities, one par package - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, matches source - pec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all files that it creates; does not create any directories, does not take ownership of other files or directories - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - no static, .la, .pc files SHOULD - builds fine in mock/devel/i386 and x86_64 - runs as advertised package is APPROVED but before importing please - fix timestamp preserving of man page (install -pm hardlink.1) - fix the %make step to take into account SMP flags (not that it would matter much for this small program, but the guidelines request it) - add to the package and include in the RPM as %doc the GPL license. It is mentioned in the C source, but it would be wise to also include it in full -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review