Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mcpp - Alternative C/C++ preprocessor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237373 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-04-23 07:10 EST ------- Hello, Matsui-san: First please make yourself be familiar with the guidelines: http://fedoraproject.org/wiki/Packaging/Guidelines and http://fedoraproject.org/wiki/Packaging/ReviewGuidelines Then: A. description section: * libdir - rpmlint shows: -------------------------------------------------------- E: mcpp configure-without-libdir-spec -------------------------------------------------------- For this package it seems okay, however please explain why not using libdir for ths configure is not a problem. Also consider to use %configure macro. * disttag - Using %{?dist} tag on Release number is prefered to make it easy to maintain a package over several branches Check: http://fedoraproject.org/wiki/Packaging/DistTag * SourceURL - Please refer to http://fedoraproject.org/wiki/Packaging/SourceURL * Prefix - Do you intend to make this package relocatable? If so, please explain why you want. If not, setting Prefix is forbidden. B. setup/build/install stage: * macros - If you don't intend to make this relocatable, please use proper macros (%{_mandir} for /usr/share/man, %{_datadir} for /usr/share, ....) * parallel make - Support parallel make if possible. * Compilar flags - Fedora specific compilation flags are not honored. Mock build log says: ---------------------------------------------------------- make[2]: Entering directory `/builddir/build/BUILD/mcpp-2.6.3/src' gcc -DHAVE_CONFIG_H -I. -I. -I. -g -O2 -c -o mcpp-main.o `test -f 'main.c' || echo './'`main.c ---------------------------------------------------------- while Fedora specific compilation flags are: ---------------------------------------------------------- [tasaka1@localhost ~]$ rpm --eval %optflags -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables ---------------------------------------------------------- (on FC-devel i386) C Files entry * Documentation entry - Files/Directories under %{_docdir} (/usr/share/doc) are automatically marked as documentation * Locale specific documentation - Locale specific documents must be marked as %lang(<lang>) (i.e. %lang(ja) %doc ..... , for example) * Encoding - doc-jp/mcpp-manual.html is encoded with EUC-JP, while Fedora default encoding is UTF-8. Please change (by iconv, for example). * Documentation The following documents are preferred to be included as a documentation. ---------------------------------------------------------- ChangeLog* ---------------------------------------------------------- D. clean section ---------------------------------------------------------- make DESTDIR=$RPM_BUILD_ROOT uninstall make distclean ---------------------------------------------------------- - Why do these required? E. test execution - These are some directory which "seem" to be used for %check section. If possible, add %check section and do some tests in the section. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review