Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: scim-tables https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226399 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Flag|fedora-review?, |fedora-review+ |needinfo?(panemade@xxxxxxxxx| |) | ------- Additional Comments From panemade@xxxxxxxxx 2007-04-23 05:07 EST ------- oops sorry for taking time. Here comes a quick review. Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPMs. + source files match upstream. 58d7f7dd231d73ef179e072b3124ebac scim-tables-0.5.7.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text COPYING is included in package. + %doc is small so no need of -doc subpackage. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no .pc files are present. + no -devel subpackage exists. + no .la files. + translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Provides: table-imengine-setup.so table.so APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review