https://bugzilla.redhat.com/show_bug.cgi?id=1125225 --- Comment #3 from Tomas Tomecek <ttomecek@xxxxxxxxxx> --- Hey Flo, thanks for taking the review. I think this should be really easy thing to do. (In reply to Florian "der-flo" Lehner from comment #1) > Even if the latest version is just some hours old. This package contains not > the latest one. Update it please and i will do a review. I haven't noticed that alot has a new upstream release, thanks for notifying me. Will definitely update it. > Whats about "%define ownerqwe asd" and the %if ... %endif around it? Whoops. I was just testing something and forgot to remove it. > Replace cp with install -p in the .spec to preserve timestamps. Sure thing. > The license from ./extra/colour_picker.py is different to the rest of the > files - please mention this. Well, stuff from extra/ is not being packaged: $ rpm -ql -p alot-0.3.6-1.fc20.noarch.rpm | grep extra | wc -l 0 > Don't you want to ship it for python3, too? It's not compatible with python 3. I guess that I could try doing 2to3 before building it [1] but I would prefer to wait for upstream support of python 3. E.g. File "alot/init.py", line 37 print alot.__version__ [1] http://fedoraproject.org/wiki/Packaging:Python#Running_2to3_from_the_spec_fil -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review