[Bug 216355] Review Request: vdr-skins - Collection of OSD skins for VDR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vdr-skins - Collection of OSD skins for VDR


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216355





------- Additional Comments From ville.skytta@xxxxxx  2007-04-22 16:31 EST -------
(In reply to comment #1)
> o Some parts under /etc should probably move into /usr/share.

Makes sense, although only the *.theme files remain in /etc/vdr/themes and that
dir can't be changed without changing it in the main vdr package as well.  Added
to my TODO list for future vdr package revisions.

> o Some URLs are broken like http://www.magoa.net/sttng-blue.theme and 
>   http://vdr.pfroen.de/download/DeepBlue-0.1.4.tar.gz.
> 
> o Due to the latter the prepare script does not work till the end.

Yeah, I've been trying to ping upstreams of skins whose download URLs no longer
work, but haven't got replies from all of them :(

Archive.org appears to have a copy of sttng-blue.theme:
http://web.archive.org/web/*/http://www.magoa.net/sttng-blue.theme

So I guess that leaves us only DeepBlue-0.1.4.tar.gz MIA.  Suggestions?  I've
had it in this package for ages, and IMHO upstream availablity/verification is
not *that* critical because it's only data.  If you feel more comfortable with
dropping it for now, will do and reintroduce later if upstream reappears.

> o The ones that were created by the script had different md5sums (but maybe
>   that's expected due to tar/bz2 timestamping, in that case: do we have some
>   tarball comparison tool?). I could only verify EgalSimple-1.0-demo.tar.bz2
>   and SilverGreen-0.1.7.tar.bz2

bunzip2'ing and comparing the uncompressed tarballs could work.  And rpmdev-diff
might be useful as well.

> [side note: why are the logos removed? Legal issues?]

They are logos of various TV and radio channels, most of which are likely
trademarked, and I haven't found any evidence that they'd be included in
upstream tarballs with the trademark holders' consent.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]