[Bug 1114212] Review Request: glite-lb-server - gLite Logging and Bookkeeping server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1114212



--- Comment #5 from František Dvořák <valtri@xxxxxxxxxx> ---
(In reply to Christopher Meng from comment #4)
> (In reply to František Dvořák from comment #3)
> > Do you think I should limit the permissions anyway? The files created by
> > gLite daemons in /var/spool/glite have 0600 permissions, so additional
> > listing permissions on directory couldn't be a problem...
> 
> Actually in BSD systems, 600 is common, no need to set if you've done the
> right thing. ;)
> 

"no need to set" sounds good to me. ;-) What do you think about new spec (not
touching the permissions by spec file)?

> > > 2. install -m 0644 ChangeLog LICENSE %{buildroot}%{_pkgdocdir}
> > > 
> > > Why not %doc?
> > > 
> > 
> > It is due to EPEL support. There is something installed in /usr/share/doc
> > already by 'make install' and EPEL 6 doesn't handle combination of already
> > existing files and %doc very well.
> 
> Using rm -frv %{buildroot}%{_docdir} at the end of %install and %doc is
> better, also %_pkgdocdir is unavailable on EPEL.

OK, it simplifies the packaging and spec is more readable (though I need to be
more careful when upgrading - new files won't be catched by build failures).

Spec URL:
http://scientific.zcu.cz/fedora/glite-lb-server-3.0.18-3/glite-lb-server.spec
SRPM URL:
http://scientific.zcu.cz/fedora/glite-lb-server-3.0.18-3/glite-lb-server-3.0.18-3.fc22.src.rpm

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7232959

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]