Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vdr-text2skin - OSD skin plugin for VDR https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216353 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|normal |medium Axel.Thimm@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From Axel.Thimm@xxxxxxxxxx 2007-04-22 09:06 EST ------- - rpmlint checks return: W: vdr-text2skin dangerous-command-in-%pre cp - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Everything looks OK including the dangerous cp, so review+ :) (AFAIU I'm not supposed to touch the assignee or status fields anymore, if I messed up, ping me) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review