[Bug 1121084] Review Request: rubygem-cocoon - Gem that enables easier nested forms with standard forms, formtastic and simple-form

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1121084

František Dvořák <valtri@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |valtri@xxxxxxxxxx



--- Comment #1 from František Dvořák <valtri@xxxxxxxxxx> ---
The build fails due to not listed files:
   /usr/share/gems/gems/cocoon-1.2.6/History.md
   /usr/share/gems/gems/cocoon-1.2.6/VERSION


And there are issues, where I'm not sure if they can (or need?) to be fixed:

1) BuildRequires

They are probably not needed:
  BuildRequires: ruby(release)
  BuildRequires: ruby

But there is no problem with them and I guess there can be some advantages to
be closer to the gem2rpm template?


2) E: non-executable-script
/usr/share/gems/gems/cocoon-1.2.6/spec/dummy/script/rails 0644L /usr/bin/env

But it's not important file, and in -doc subpackage.


3) E: summary-too-long

The initial "Gem that enables " could be easily cut off. But fixing that would
mean summary different from the original gem...


4) E: zero-length ...

Probably no way to solve the favicon.ico file. The .gitkeep could be removed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]